Make initial cleanse optional #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This in combination with Fotorama was causing bugs in Chrome for some reason. I still can't figure out why removing transition & transform by cleansing them 5 seconds before Fotorama was initialized caused bugs but it did. This is probably the weirdest bug that I've ever encountered. In any case - an optional initial cleanse doesn't hurt. Maybe someone has set up their initial transforms & transitions for some reason, or encounters a weird chrome bug like I did.
|
This only fixes a part of the problem. The rest being - animo cleans out transforms & transitions even though only animations are being used. "Not cleansing" and setting keep to true actually makes it only worse... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in combination with Fotorama was causing bugs for me in Chrome for some reason. I still can't figure out why removing transition & transform by cleansing them even 60 seconds before initializing Fotorama caused bugs, but it did. This is probably the weirdest bug that I've ever encountered.
In any case - an optional initial cleanse doesn't hurt. Maybe someone has set up their initial transforms & transitions for some reason, or encounters a weird chrome bug like I did.