Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package.json #28

Closed
lamuertepeluda opened this issue Nov 17, 2015 · 7 comments
Closed

Add package.json #28

lamuertepeluda opened this issue Nov 17, 2015 · 7 comments

Comments

@lamuertepeluda
Copy link
Contributor

Hi,

could you please add a package.json file for npm support so that it could be installed via npm (see this issue)? Adding to npm registry would also be appreciated.

Thanks, BR

Vito

@ThrivingKings
Copy link
Owner

Hi Vito— I definitely think it should be added to bower but it doesn't make much sense to me to install animo as a node module.

@ThrivingKings
Copy link
Owner

bower install animo

@lamuertepeluda
Copy link
Contributor Author

Well Daniel, that's true unless you're using build tools like webpack as I do (webpack is omnivore).
And you can have your library published on both npm and bower (and anything else you like) without conflicts as jQuery does.

@ThrivingKings
Copy link
Owner

It's not ideal, but you can use bower components with webpack (https://webpack.github.io/docs/usage-with-bower.html). My hesitation is that animo really isn't a node module so I don't like the idea of it being available there. Do you mind telling me a little about how you're hoping to use animo in your project? Are you just looking to expose animo to all of your components?

@ThrivingKings
Copy link
Owner

thought about it and you're right. no reason for it not to be available via npm as well. just merged your PR. thanks!

@lamuertepeluda
Copy link
Contributor Author

great 👍

At the moment I'm working on a p.o.c. for a project, so not even a real project, for a mobile app based on Apache Cordova...

I was looking for something that would make easier to include great Animate.css animations with jQuery and having control of what's going on, and then I found this very useful library of yours... :)

I know I could've used bower for front-end deps and then perhaps add a "npm preinstall" script for downloading the bower deps first, set bower_dependencies path into my webpack config and so on, but npm is also fine for me. And as you said there is no reason for not making it available via npm. So thank you very much!

@ThrivingKings
Copy link
Owner

Cool! Sorry for the brief back and forth about it and best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants