Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosine similarity vs cosine distance #182

Closed
tazitoo opened this issue Mar 16, 2022 · 3 comments · Fixed by #184
Closed

cosine similarity vs cosine distance #182

tazitoo opened this issue Mar 16, 2022 · 3 comments · Fixed by #184

Comments

@tazitoo
Copy link

tazitoo commented Mar 16, 2022

Wanted to say thanks for the repo - this is a giant leap forward in scaling k-medoids.

I noticed that one of the distance metrics available is cosine similarity - not cosine distance which is 1 - cosine similarity. My intuition tells me dist(me, me) should be zero, and not one.

If using cosine similarity is intentional, I could put in a PR for cos_dist.

@motiwari
Copy link
Owner

Thanks for the bug report. I have a release going out this week that will address this.

@motiwari
Copy link
Owner

Sorry for the delay. I've fixed this in 6f6de6b, which will go out in a release shortly.

@tazitoo
Copy link
Author

tazitoo commented Mar 23, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants