New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cosine similarity vs cosine distance #182
Comments
Thanks for the bug report. I have a release going out this week that will address this. |
motiwari
pushed a commit
that referenced
this issue
Mar 21, 2022
Sorry for the delay. I've fixed this in 6f6de6b, which will go out in a release shortly. |
Awesome - thanks for the quick fix.
...on the lam.
… On Mar 21, 2022, at 19:42, Mo Tiwari ***@***.***> wrote:
Sorry for the delay. I've fixed this in 6f6de6b, which will go out in a release shortly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wanted to say thanks for the repo - this is a giant leap forward in scaling k-medoids.
I noticed that one of the distance metrics available is cosine similarity - not cosine distance which is 1 - cosine similarity. My intuition tells me dist(me, me) should be zero, and not one.
If using cosine similarity is intentional, I could put in a PR for cos_dist.
The text was updated successfully, but these errors were encountered: