Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arbitrary distance metrics #4

Open
motiwari opened this issue Jan 7, 2021 · 2 comments
Open

Support arbitrary distance metrics #4

motiwari opened this issue Jan 7, 2021 · 2 comments
Labels
feature For new features

Comments

@motiwari
Copy link
Owner

motiwari commented Jan 7, 2021

We should have an easy way for users to incorporate their own dissimilarity metrics. Users should be able to write their dissimilarity metric in Python, which is then called via the C++ code.

User feedback suggests allowing users to pass the reference to the function that will compute distances. Asking the user to supply the O(n^2) distance matrix is of course infeasible.

This is a several-step task, including:

  1. Making the Python function callable via the C++ (C++ bindings for the Python code); perhaps via some translation
  2. Updating the C++ code to use this custom function. Some relevant code
@motiwari motiwari added the feature For new features label May 28, 2021
@motiwari motiwari added this to the 8-6-21 milestone Jul 31, 2021
@motiwari motiwari modified the milestones: 8-13-21, 8-20-21 (Release) Aug 18, 2021
@tanweer-mahdi
Copy link

Hi @motiwari , do you currently recommend implementing custom distance metrics locally? Or shall I create a branch, code the distance metric in C++ as you suggested in the README and create a PR?

@motiwari
Copy link
Owner Author

motiwari commented Jan 9, 2022

@tanweer-mahdi the latter option is welcome and I'd be happy to review a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature For new features
Projects
None yet
Development

No branches or pull requests

3 participants