Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with NaN in NumericOpsExpOpt #60

Open
mdashti opened this issue May 25, 2013 · 0 comments
Open

Dealing with NaN in NumericOpsExpOpt #60

mdashti opened this issue May 25, 2013 · 0 comments
Labels
bug

Comments

@mdashti
Copy link
Collaborator

mdashti commented May 25, 2013

Currently we have trivial optimization of converting "X = Y * 0" to "X = 0" in NumericOpsExpOpt trait and it works fine for integers, but it is not a correct optimization considering IEEE standard for floating point operations (NaN * 0 = NaN). I think, disabling this optimization for Double and Float numbers is the correct solution. Does anyone have any comments?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdashti