Added the ability to set the background color #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 methods for setting the background color of the Elastic view. It should take in either an int color or a String and parse the color. If the string is null or the parsing fails, nothing will be set and it will retain the original color
| @@ -107,5 +107,33 @@ public void onEnterAnimationFinished() { | |||
|
|
|||
| // Do further actions if necessary | |||
| } | |||
|
|
|||
|
|
|||
| ///////////////////////////////////////////////////////////////////////////// | |||
There was a problem hiding this comment.
You can remove that comment, it's not really necessary
|
Thanks for the tips. Were you wanting me to change the code prior to merge? Or were you just offering advice? |
|
That's better if you change it, it should be quick to do it ;) |
Adjusted text and changed catch argument. Omitted an e.printStackTrace() as I was unsure if it was desired. Let me know if you want it implemented.
|
Updated with said fixes. Let me know if you need anything else changed on there, I will be happy to do it. |
| * Color.parseColor(string) | ||
| */ | ||
| public void setBackgroundColor(String passedColor) { | ||
| if(passedColor == null){ |
There was a problem hiding this comment.
this if needs a space between itself and the parenthesis (like the rest of the code).
There was a problem hiding this comment.
Just missing if (passedColor == null) (adding a white space) and it's good to go.
e.printStackTrace(); under catch for null Strings or bad color parsing strings sent
F7D
added a commit
to F7D/ElasticDownload
that referenced
this pull request
May 1, 2018
Added the ability to set the background color Signed-off-by: f7d <vp7@usa.com>
F7D
added a commit
to F7D/ElasticDownload
that referenced
this pull request
May 1, 2018
Added the ability to set the background color Signed-off-by: f7d <vp7@usa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 methods for setting the background color of the Elastic view. It should take in either an int color or a String and parse the color. If the string is null or the parsing fails, nothing will be set and it will retain the original color