Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@separate, @unite, @summary #18

Merged
merged 15 commits into from
Aug 4, 2023
Merged

@separate, @unite, @summary #18

merged 15 commits into from
Aug 4, 2023

Conversation

drizk1
Copy link
Member

@drizk1 drizk1 commented Aug 3, 2023

Update includes
@separate, @unite and @summary with docstring and examples
@summary docstring - had to use ; because table was too wide and i couldnt correctly copy width

@drizk1 drizk1 changed the title @separate, @unite, @summary, fill_na @separate, @unite, @summary Aug 3, 2023
@kdpsingh
Copy link
Member

kdpsingh commented Aug 4, 2023

@drizk1 is this ready to merge from your standpoint?

@kdpsingh
Copy link
Member

kdpsingh commented Aug 4, 2023

I can take a look at the docstring issue for @summary if that's all that's left.

@drizk1
Copy link
Member Author

drizk1 commented Aug 4, 2023

That would be awesome. I can't figure out how to reproduce the evaluated output because it omits the last column due to width so the expected won't match evaluated.

@kdpsingh
Copy link
Member

kdpsingh commented Aug 4, 2023

We'll figure out the docstrings later - I updated this PR with the changes from the main branch and will merge this PR for now.

In a future update, we can considering making @summary() work with strings and categoricals.

@kdpsingh kdpsingh merged commit 66b8639 into TidierOrg:main Aug 4, 2023
3 checks passed
@drizk1
Copy link
Member Author

drizk1 commented Aug 4, 2023

Incredible. I'll def start moving @summary towards that goal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants