Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness probes of some components not correct #71

Open
TilBlechschmidt opened this issue Dec 7, 2021 · 1 comment
Open

Readiness probes of some components not correct #71

TilBlechschmidt opened this issue Dec 7, 2021 · 1 comment
Labels
Priority: High Highest priority that will be addressed first once contribution time is available Status: Pending Initial issue stage waiting for further evaluation Type: Bug Issues that affect the operation of the software

Comments

@TilBlechschmidt
Copy link
Owner

馃悰 Bug description

It appears that some components do not propagate the correct readiness probe state regarding connectivity to the Redis server. It seems to be affecting the manager, orchestrator, and gangway. The collector and api probably suffer the same issue but in the observed scenario they kept on crashing because the mongodb server was unavailable.

馃Χ Reproduction steps

Steps to reproduce the behavior:

  1. Deploy a webgrid fresh
  2. Make sure the redis and/or MongoDB don't come up
  3. Watch it burn 馃敟

馃幆 Expected behaviour

This is more of a philosophical discussion on whether the software should crash upon encountering an error or just report a negative readiness state. Probably the latter, however, even that is currently not given. Redis connectivity should be reflected in the readiness state!

馃摵 Screenshots

image

@TilBlechschmidt TilBlechschmidt added Type: Bug Issues that affect the operation of the software Priority: High Highest priority that will be addressed first once contribution time is available Status: Pending Initial issue stage waiting for further evaluation labels Dec 7, 2021
@TilBlechschmidt TilBlechschmidt added this to the Stable release milestone Dec 7, 2021
@TilBlechschmidt TilBlechschmidt self-assigned this Dec 7, 2021
@TilBlechschmidt
Copy link
Owner Author

image

After giving it a few minutes to settle down, it appears as though the api and collector crash (as expected), the gangway correctly report the readiness, and the manager and orchestrator behave incorrectly.

@TilBlechschmidt TilBlechschmidt removed their assignment Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Highest priority that will be addressed first once contribution time is available Status: Pending Initial issue stage waiting for further evaluation Type: Bug Issues that affect the operation of the software
Projects
None yet
Development

No branches or pull requests

1 participant