feat(generator): implement fix(?) for issue #4 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimMikeladze
requested changes
Apr 26, 2022
If both `count` and `colors` parameters are passed, but length of `colors` is less than `count`, randomly generate extra colors to satisfy the desired color count.
jalavosus
force-pushed
the
generator/fill-extra-colors
branch
from
ae7d0ff
to
4138b74
Compare
|
Thank you! This project is super cool, and you've done an excellent job with it :) Also, your code is super clean and pleasant to work with, so thanks for that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both
countandcolorsparameters are passed, but length ofcolorsis less thancount, randomly generate extra colors to satisfythe desired color count.
Closes #4.