Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOPasscodeKeypadView is inaccessible #41

Closed
ARGAMX opened this issue Mar 24, 2020 · 4 comments
Closed

TOPasscodeKeypadView is inaccessible #41

ARGAMX opened this issue Mar 24, 2020 · 4 comments

Comments

@ARGAMX
Copy link

ARGAMX commented Mar 24, 2020

Hello.

I have made TOPasscodeViewController.framework file from this project manually downloaded it.
After I have Included this framework in Swift project.
Made import TOPasscodeViewController.
All was perfect, even can chow TOPasscodeViewController on screen.
Seems all OK.

BUT.

When I started customization I found some limitations.
TOPasscodeKeypadView under TOPasscodeView is inaccessible.
Other simple props, like titleLabel is accecable.
But keypadView and inputField is not.

http://dl3.joxi.net/drive/2020/03/24/0014/1145/935033/33/2f38cbf5f1.jpg

http://dl3.joxi.net/drive/2020/03/24/0014/1145/935033/33/0950b88d93.jpg

Looks like not expected behavior, because it prevents from customization KeypadView.
Now I am try to make it public and accessible. (move it from Private Headers to Headers)

How I can access keypadView?

Thanks.

@ARGAMX
Copy link
Author

ARGAMX commented Mar 24, 2020

I have resolved that problem and made PR:

#43

@ARGAMX
Copy link
Author

ARGAMX commented Mar 24, 2020

Also I am thinking about to make other private props available too.
Because that nice framework suffering from Apple Review I think it should provide more customizations properties.

@TimOliver
Copy link
Owner

Aha. Nice catch! Thanks for the PR!

Yes, it's a bit inconvenient that it has to be redesigned for that reason. Other users have reported that changing the circles to squares has worked in the past.

I plan to do a proper redesign soon. :)

@TimOliver
Copy link
Owner

Closed due to PR #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants