-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Feedback #106
Comments
Development build documentation has a missing semicolon for bar and workspace settings. Also the font setting under bar now needs to be enclosed in quotes, when in ymal it didn't need to be. |
Added.
That's just the difference in file formats. Because |
Got it that makes sense. Just figured I would mention it as it might cause confusion as people migrate from yaml to rhai as it wasn't mentioned in the new docs. |
What exactly is it that makes you not happy about the documentation? Is it the organization of the content in the readme or the wording? Is it the amount of content? Should parts be moved to the wiki? I did think with the improvements you've made to the configs along with the list of modular features you've added it might be good to have somewhere that lists custom configs from users. |
Reading the documentation is very inconvenient. The readme has gotten so long, that you have to scroll a lot to go to the parts you are looking for. The style is inconsistent, the structure could be better and there could be a lot more documentation. Writing the documentation is also very cumbersome, because everything lives in one big file. I will probably move the documentation from the README to a wiki or even into a website (might be overkill).
That's a good suggestion! |
I am currently rewriting the documentation and I would really appreciate it if some of you would read the new documentation and give me some feedback. https://timuntersberger.github.io/nog |
I like it so far just needs more content filled out, I think. It'd be nice if there were more example images and gifs on the front page showing maybe other applications too. Maybe also a short blurb on what a tiling window manager is and what existing/planned features nog has (maybe could be just a link to a filtered list of the github issues)? |
Yeah looking good so far, I agree with ramiezmike about more images and gifs. Maybe each settings can have a gif demonstrating what it actually does. Also font size could be increased by a point or two imo. |
in the bar config doesn't work I think because it's expecting single quote to be a character. Also, not sure if it's because of my branch switching but once I got to the point where I was using these .nog configs locally the default script that generated just gave me a blank app_bar... but I think the config you have here works fine. |
Yeah sorry you need to use |
That's because currrently there isn't really a default combination of components. I am going to add one today. |
The preview video is neat but what is the thing you use to open programs? Because A) I want that and B) it's not clear that it's not part of nog? Also, I noticed on my phone at least when switching pages using the menu it retains the scroll of the page I left. So, sometimes it will load the next page but already be scrolled down half the page. Also, maybe there should be some information about the tray icon and how it has the ability to reload nog + a suggestion to use it if the user runs into an issue as a way to resolve it without losing their setup. |
https://timuntersberger.github.io/nog/#/configuration/keybindings?id=launch
👍 |
Sorry, not the launch keybinding, this thing that you're using to search and launch apps |
|
looking at latest on the custom-language branch (not sure where the best place to discuss this is?) On the functions page there's this example
Might be good to add a print statement in the function too like this to further demonstrates that the function retains its own copy across calls to it
Using this, I was able to write this toggle which I was super excited about:
Separately, I was a little confused with the "elif" in the conditionals example:
was that intended to be "elif true"? |
👍
whoops.... I swapped |
I am currently rewriting the documentation using mdbook which has this and dark mode included.
👍 |
Ah, sorry was trying to add a comment and hit the close button by accident Was able to look over the bulk of the config changes +1 One thing I did have a question on is in the nogscript's nog API signatures, like for bind you have this (bool, callback, string)
and the example's parameter order is (string, callback)
And this is an example from your config example (string, callback, bool)
Am I misunderstanding the signature ordering or is it reversed? |
@ramirezmike yeah I accidently reversed the order. |
I finally realized what my issue was with using the nog.launch binding. In the old rhai configs, I had strings with backward slash escapes
But the new parsing crashes on the \. However it works with forward slashes
I don't know if it's something worth fixing but maybe we should add a note in the launch documentation instead? |
@ramirezmike that is 100% a bug. I will fix it later this week. |
Seems like the link to the documentation is currently broken. |
The functions exposed on nog.window and nog.workspace seem to be missing from the generated documentation book. |
@keepitsane @ramirezmike both fixed. |
The link to the bar example seems to be broken. The bar example link on that doc page links to the following:
In previous versions it used to be double back slashes, now it is double forward slashes. Maybe a note should be included of this change in a migration guide for those using the old |
There is a large gap in getting from 0 to 1. I think I'm reasonable technical but I'm having a touch time getting started. I'm coming 'yabai' + 'skhd' on MacOS and 'i3' on Linux so perhaps it clouds my understanding. I expect a fairly straight forward process to standing up a minimal nog. Ideally nog would explicitly configure the config.ns with at least:
It would be a good baseline to get someone acquainted with how nog works. From there, they can get more information from the existing docs. The blank config.ns presented a bar but beyond that I had no clue how to operate nog. Next I copied the example config but I still find that I'll getting something basic to happen is not completely apparent. |
Perhaps we should have nog copy a baseline config on startup if none exists. There are some defaults it loads but I think without a config.ns you may not get many keybindings
The way nog works it won't show a workspace if it's empty, so.. I don't think we can just configure workspaces that appear. Is that what you mean?
This is really dependent on what programs are installed on the user's machine. Do you mean a keybinding for making nog manage an existing window or do you mean a keybinding for launching something like chrome?
Are you suggesting something like an in-app tutorial or just better defaults in the config?
Feel free to post more questions and I can walk you through it or maybe open a topic in discussions. I'd like to get the documentation to a state where it's much more user friendly and knowing where the pain points are helps. |
#259 will contain a rewrite of the documentation so if anyone has any feedback regarding the documentation please tell me now so I can consider it when rewriting the docs. |
It turns out that the example configurations worked just fine. It was just a bit intimidating to start nog and then not know what to do next. So here are a couple of things that I think could improve the on-boarding experience.
Currently the docs are decent at providing reference information but the Quick Start guide doesn't live up to it's purpose. Quick Start guides should be based on concrete example of how to basically operate the software. The current Quick Start guide only explains how to install nog. |
I am currently not very happy with the structure of the documentation, but I don't really know how to improve it.
I'd appreciate any kind of feedback regarding this.
The text was updated successfully, but these errors were encountered: