Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constant signal class #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

wenboown
Copy link

Thanks for making the library available. It is very helpful to me. I encountered a situation where I need a constant signal so I just created a class for it.

@codecov-io
Copy link

codecov-io commented Mar 21, 2019

Codecov Report

Merging #10 into master will decrease coverage by 0.11%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   48.77%   48.65%   -0.12%     
==========================================
  Files          17       18       +1     
  Lines         285      298      +13     
==========================================
+ Hits          139      145       +6     
- Misses        146      153       +7
Impacted Files Coverage Δ
timesynth/signals/constant.py 46.15% <46.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ae9013...28336a3. Read the comment docs.

@darigovresearch
Copy link

@wenboown thanks for taking the time to make a pull request, are you able to make some tests to manage the coverage of the automatic message above?

Do the maintainers need anything else to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants