Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon is not showing up #9

Closed
Timecraft opened this issue Nov 12, 2019 · 7 comments
Closed

Icon is not showing up #9

Timecraft opened this issue Nov 12, 2019 · 7 comments
Labels
help wanted Extra attention is needed

Comments

@Timecraft
Copy link
Owner

Timecraft commented Nov 12, 2019

Upon installing (in a virtual machine), the icon for JS Test is not showing up; it is showing the default icon.
Icon Not Showing
Ephemeral's icon shows up and its icon can be found on manual change of JS Test's .desktop file to point to com.github.cassidyjames.ephemeral, but neither JS Test or Ephemeral can find the icon when pointed to com.github.timecraft.jstest com.github.timecraft.js-test

@Timecraft Timecraft pinned this issue Nov 12, 2019
@Timecraft Timecraft added the help wanted Extra attention is needed label Nov 12, 2019
@Timecraft
Copy link
Owner Author

After some testing in the VM, the icon shows up after giving the .desktop file a direct path to /usr/local/share/icons/hicolor/128x128/apps/com.github.timecraft.js-test.svg

What the absolute heck

@Timecraft
Copy link
Owner Author

Timecraft commented Nov 13, 2019

SO. I told it to look at com.github.timecraft.jstest for its icon. That works.

LET US NOTE THAT THE FILE IS NAMED com.github.timecraft.js-test.svg WITH A HYPHEN.

@Timecraft
Copy link
Owner Author

Timecraft commented Nov 13, 2019

NOPE THAT DIDN'T WORK.

Edit: I'm not mad, I swear

@Timecraft Timecraft reopened this Nov 13, 2019
@Timecraft
Copy link
Owner Author

Tested it on a physical machine for kicks and giggles, no change. Icon still does not appear.

@Timecraft
Copy link
Owner Author

Tested changing the file name to simple js-test.svg and having the desktop file point to js-test, but to no avail

@Timecraft
Copy link
Owner Author

Ok, so a small test showed that commit 301ff8f may have fixed the issue, even though that commit had nothing to do with the icon 🤔

@Timecraft
Copy link
Owner Author

Timecraft commented Nov 13, 2019

Works now
As can be seen, that commit did fix the icon!
Not sure why, but it did!
Edit: I should also note that this IS in a fresh install in a virtual machine, so there's no contaminants

@Timecraft Timecraft unpinned this issue Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant