Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing binaries for Electron v28 and v29 #324

Closed
rbolink opened this issue Apr 19, 2024 · 6 comments
Closed

Missing binaries for Electron v28 and v29 #324

rbolink opened this issue Apr 19, 2024 · 6 comments

Comments

@rbolink
Copy link

rbolink commented Apr 19, 2024

I'm building an Electron app (v29.3.1) using the Electron builder package. However, when doing this I'm getting the following error:

afbeelding

It seems like binaries for Electron v28 and v29 are missing when looking at the releases. Will these be added anytime soon?

@TimelordUK
Copy link
Owner

v28 does not compile and that wont be looked at any time soon - v29, v30 both seem to compile I will release binaries for these shortly in coming day or so

@rbolink
Copy link
Author

rbolink commented Apr 22, 2024

@TimelordUK I saw that you released v4.2.0 of the package. However, when looking at the files that belong to this tag it seems like the new changes are not included. The package.json also contains version: 4.1.2 instead of version: 4.2.0. Did something go wrong during the release or am I just too impatient?

@TimelordUK
Copy link
Owner

TimelordUK commented Apr 22, 2024

I’ll check tonight. The binaries should be attached to the release the tar gz. I have not released anything to npm presently.

@TimelordUK
Copy link
Owner

i recreated release, i will push to npm in a day or so - v29,v30 should be working on this release

@rbolink
Copy link
Author

rbolink commented Apr 23, 2024

@TimelordUK Thanks! Will close this issue if the release is working

@rbolink
Copy link
Author

rbolink commented Apr 30, 2024

@TimelordUK It all seems to work, so I'm closing the issue. Thanks for adding the binaries on this short term!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants