Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling signing when experimenting #3

Closed
FauxFaux opened this issue Jun 10, 2021 · 1 comment
Closed

Consider disabling signing when experimenting #3

FauxFaux opened this issue Jun 10, 2021 · 1 comment

Comments

@FauxFaux
Copy link
Contributor

The commit.gpgsign option adds 300ms+ of latency to each commit, making a large rebase take minutes instead of seconds.

Can the tool toggle it off? Explicitly opt out?

I'd like it on for the final rebase of the branch, as the commits should be signed on the final branch, but there's no need for it to be on (slowing everything down) while messing around?

@Timmmm
Copy link
Owner

Timmmm commented Jun 14, 2021

Ah yeah we should definitely turn it off for the rebase that figures out where conflicts are. I think you just need to add something like -c commit.gpgsign=false on this line (not too sure though; I have never used commit signing).

More difficult to turn it off for the slow method, but given that is not the default it probably doesn't matter.

PR welcome! :-)

Also 300ms for signing seems crazy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants