Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting workspace versioning #7

Closed
max-sixty opened this issue Dec 9, 2022 · 3 comments · Fixed by #10
Closed

Supporting workspace versioning #7

max-sixty opened this issue Dec 9, 2022 · 3 comments · Fixed by #10

Comments

@max-sixty
Copy link

Describe the bug
Does this crate support workspace versioning? I'm getting an error when attempting to run it on prql-compiler. Here's the issue template:

❯ unused-features analyze --log-level debug
[2022-12-09T00:21:11Z INFO  unused_features::subcommands::analyze] /Users/maximilian/workspace/prql/prql-compiler
[2022-12-09T00:21:11Z DEBUG unused_features::cargo_project] Loading '/Users/maximilian/workspace/prql/prql-compiler/Cargo.toml' ...
[2022-12-09T00:21:11Z DEBUG unused_features::cargo_project] Successfully read the toml file.
[2022-12-09T00:21:11Z DEBUG unused_features::cargo_project] Parsing toml definition ...
[2022-12-09T00:21:11Z ERROR unused_features::subcommands::analyze] Failed to load '/Users/maximilian/workspace/prql/prql-compiler/Cargo.toml' crate. invalid type: map, expected a string for key `package.version` at line 8 column 21
[2022-12-09T00:21:11Z INFO  unused_features] Finished the process
  • The target-os and architecture used for building — MacOS, arm64
  • Any optional specified CLI configuration flags.

Thank you!

@TimonPost
Copy link
Owner

I am using those libs to do the analyzing of the crate:

cargo_toml= { version="0.11.5", default-features = false }
toml= { version="0.5.9", default-features = false }
serde= { version="1.0", default-features = false }
toml_edit = { version = "0.14.4", default-features = false }

So depends a bit if they support it and how new the feature is

@max-sixty
Copy link
Author

cargo_toml looks well maintained, and 0.11.5 is nine months old, so my guess is that bumping that will fix it...

@jayvdb
Copy link
Contributor

jayvdb commented Feb 8, 2023

I was able to workaround this by bumping a few deps, and updating a few bits of code. Some of my changes are inadequate, but I will put up a PR anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants