Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be smarter about fetching pull requests #3

Open
TimonVS opened this issue Sep 20, 2018 · 1 comment
Open

Be smarter about fetching pull requests #3

TimonVS opened this issue Sep 20, 2018 · 1 comment
Assignees
@TimonVS

Comments

@TimonVS
Copy link
Owner

TimonVS commented Sep 20, 2018

We currently fetch all pull requests and after that we filter the pull requests to only include PRs that have been merged since the last release. We could add some sort of callback to the paginate function to make it stop once it has fetched the PRs we need.
@TimonVS TimonVS self-assigned this Sep 20, 2018
@TimonVS
Copy link
Owner Author

TimonVS commented Oct 5, 2018

Instead, we can use the search endpoint to get pull requests that are merged after a certain date: https://help.github.com/articles/searching-issues-and-pull-requests/#search-by-when-a-pull-request-was-merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimonVS TimonVS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimonVS