Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request - Inno Setup script #24

Closed
bovirus opened this issue Oct 26, 2023 · 1 comment
Closed

Enhancement Request - Inno Setup script #24

bovirus opened this issue Oct 26, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bovirus
Copy link
Collaborator

bovirus commented Oct 26, 2023

Brief summary of your request

Improvements about installer Inno Setup script

Request details

@t

I have some request about current installer script

"View the ReadMeFile" is untranslated

Why did yoiu use this string

SetupWindowTitle = Setup - {#MyAppName} {#MyAppVersion}

that means to show "Setup - xxx xxxx" also in Italian?
The stringID "SetupWindowTitle" is already localized in each .isl Inno Setup language file.

Is missing "UninstallDisplayName="
Is missing "AppSupportURL="
I missing "AppUpdatesURL="

The value "https://github.com/Timthreetwelve/GetMyIP" can be set through define
The value "EBEA37CE-1C9C-44C2-ACE3-102E6BF79364" (appID) can be set via define

Is missing "DeleteConfigFiles" string text message
mres := MsgBox(CustomMessage('DeleteConfigFiles'), mbConfirmation, MB_YESNO or MB_DEFBUTTON2)

Is missing "AppIsRunning" string text message
Answer := MsgBox(ThisApp + ' ' + CustomMessage('AppIsRunning'), mbError, MB_OKCANCEL);

Please define these two string in english.

If you agree I can post a PR for the Inno Setup script.

Anything else?

No response

@Timthreetwelve
Copy link
Owner

Thanks for your help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants