Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement - Set by default program to use Windows system language #39

Closed
bovirus opened this issue Sep 23, 2023 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@bovirus
Copy link
Collaborator

bovirus commented Sep 23, 2023

Brief summary of your request

Modify installer to use System language

Request details

@Timthreetwelve

I installed the new version where is available my language (italian) but the installer leave unchanged the settings set by previous version (English).

Modify installer/configuration to use by default Windows system language.

For me is teh best settings.

Thanks.

Anything else?

No response

@bovirus bovirus added enhancement New feature or request needs triage Issue needs to be triaged labels Sep 23, 2023
@Timthreetwelve Timthreetwelve removed the needs triage Issue needs to be triaged label Sep 26, 2023
@Timthreetwelve
Copy link
Owner

@bovirus, I've given this a lot of thought. The issue that you ran into is unique for the case where an existing version that didn't have the desired language was upgraded to a version that now has the desired language. Once the desired language is selected, the settings file is updated, and that language will be used going forward until it is changed again. This should only happen once. Please let me know if it reverts in a subsequent installation.

I could change the default of the UseOSLanguage setting to true and that would cause the app to use the current culture language IF that language has been included in the app. However, this would only be useful for new installations, not updates. See the language selection logic in App.xaml.cs. starting at line 37.

WUView_2023-09-26_17-10-46

The UseOSLanguage setting is the checkbox (in green).

I hope this explains what is happening.

@bovirus
Copy link
Collaborator Author

bovirus commented Sep 27, 2023

@Timthreetwelve

I beleieve that enable automatic OS language/application language match (if availble) is a good option.

Of course is suful for each new installation.

@bovirus
Copy link
Collaborator Author

bovirus commented Sep 28, 2023

@Timthreetwelve

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants