Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable Redesign #7

Merged
merged 5 commits into from Aug 22, 2016
Merged

Customizable Redesign #7

merged 5 commits into from Aug 22, 2016

Conversation

JustinJiaDev
Copy link
Contributor

@JustinJiaDev JustinJiaDev commented Aug 22, 2016 •
edited

Advantages

  1. This redesign allows us to remove duplicate protocols (e.g. CustomFont and CustomLabelFont) while still maintaining compile time check.
  2. This redesign allows third party views to support Overlay.

@JustinJiaDev JustinJiaDev changed the title Customizable Redesign [WIP] Customizable Redesign Aug 22, 2016
@JustinJiaDev JustinJiaDev added enhancement New feature or request high priority This is really important labels Aug 22, 2016
@JustinJiaDev JustinJiaDev self-assigned this Aug 22, 2016
@JustinJiaDev JustinJiaDev changed the title [WIP] Customizable Redesign Customizable Redesign Aug 22, 2016
@JustinJiaDev
Copy link
Contributor Author

CI failure seems unrelated.

@JustinJiaDev JustinJiaDev merged commit ebbc796 into master Aug 22, 2016
@JustinJiaDev JustinJiaDev deleted the customizable-redesign branch August 22, 2016 17:53
@JustinJiaDev JustinJiaDev restored the customizable-redesign branch August 27, 2016 11:54
@JustinJiaDev JustinJiaDev deleted the customizable-redesign branch August 27, 2016 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JustinJiaDev JustinJiaDev

Labels
enhancement New feature or request high priority This is really important
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JustinJiaDev