Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ramda from dependencies. #3

Closed
guillaumearm opened this issue Oct 8, 2016 · 4 comments
Closed

remove ramda from dependencies. #3

guillaumearm opened this issue Oct 8, 2016 · 4 comments
Assignees
@guillaumearm

Comments

@guillaumearm
Copy link
Collaborator

remove ramda dependency.

just recode :

  • R.path
  • R.adjust
  • R.toUpper
  • R.join

don't forget to edit middleware.js and use typeof instead of R.is

note: you can edit spy() function from middleware.spec.js, now he doesn't need his constructor mutation.
@guillaumearm guillaumearm mentioned this issue Oct 8, 2016
Closed
@jvincent42
Copy link
Collaborator

Possible to keep it in devDependencies ? for testing purpose in .spec.js files.

@guillaumearm
Copy link
Collaborator Author

sure ;-)

@guillaumearm
Copy link
Collaborator Author

guillaumearm commented Oct 8, 2016 •
edited

need to complete #7 before do this (avoiding git conflict).
@JalilArfaoui, we need you.

@JalilArfaoui
Copy link
Contributor

Merged !

@guillaumearm guillaumearm self-assigned this Oct 9, 2016
alejandrofdiaz pushed a commit to alejandrofdiaz/redux-polyglot that referenced this issue Jul 24, 2023
@cicloon
Merge pull request Tiqa#3 from cabify/type-the-reducer
9da3591 
Type the reducer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guillaumearm guillaumearm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JalilArfaoui @jvincent42 @guillaumearm