Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getLocale()/getPhrases() can return a falsy value. #17

Open
guillaumearm opened this issue Oct 9, 2016 · 3 comments
Open

getLocale()/getPhrases() can return a falsy value. #17

guillaumearm opened this issue Oct 9, 2016 · 3 comments
Assignees
Milestone

Comments

@guillaumearm
Copy link
Collaborator

guillaumearm commented Oct 9, 2016

for v1.0

need #16

this will stop the progression :

  • if getLocale() or getPhrases() return or resolve a falsy value, should return next(action)
  • add 'previousLocale' as second parameter of getLocale() to determine if the locale have been changed.

about this behavior :

  • need tests
  • need doc
@JalilArfaoui
Copy link
Contributor

I think it should return next(action), not return action

@guillaumearm
Copy link
Collaborator Author

yes, you're right.
i don't remember why I thought to do that when I wrote this issue :)

@guillaumearm
Copy link
Collaborator Author

I remember ! (for return action)

it's about SET_LANGUAGE action. we shouldn't propagate this action ( and only this action ) when return a falsy value.

but that's no longer news since #38. so don't worry about this ;-)

@guillaumearm guillaumearm self-assigned this Oct 20, 2016
@guillaumearm guillaumearm added this to the v0.4 milestone Dec 6, 2016
@guillaumearm guillaumearm modified the milestones: v1.0, v0.4 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants