Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mandown 1.0.4 #121624

Merged
merged 2 commits into from
Apr 2, 2023
Merged

mandown 1.0.4 #121624

merged 2 commits into from
Apr 2, 2023

Conversation

chenrui333
Copy link
Member

@chenrui333 chenrui333 commented Jan 27, 2023 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

continuing #92452
fixes Titor8115/mandown#35

@chenrui333 chenrui333 mentioned this pull request Jan 27, 2023
Closed
@chenrui333 chenrui333 added help wanted Task(s) needing PRs from the community or maintainers linux Linux is specifically affected labels Jan 27, 2023
@carlocab carlocab added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. test failure CI fails while running the test-do block labels Jan 30, 2023
@carlocab
Copy link
Member

Build succeeds on Linux now, but the new test is failing.

@carlocab
Copy link
Member

Tested in a Docker container; can't repro the failure. Not sure what's happening? CC @Homebrew/linux

@chenrui333
Copy link
Member Author

maybe ignore linux test and move on?

@carlocab
Copy link
Member

Fine with me.

@p-linnane
Copy link
Member

Are we merging this?

@carlocab
Copy link
Member

carlocab commented Apr 1, 2023

We should.

@p-linnane
Copy link
Member

Should we rebase first? I'm terrified of what's gonna happen if we add the autosquash label to this 😅

@carlocab
Copy link
Member

carlocab commented Apr 1, 2023

Yea, probably. Though if you're already rebasing, may as well squash while you're at it.

@chenrui333 @p-linnane
mandown 1.0.4
4dca8f4 
Signed-off-by: Rui Chen <rui@chenrui.dev>

mandown: needs libconfig in runtime

mandown: fix build

mandown: tweak test

mandown: tweak test (again)
@p-linnane p-linnane removed the help wanted Task(s) needing PRs from the community or maintainers label Apr 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2023

:shipit: @carlocab has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 2, 2023
@github-actions github-actions bot added the no Linux bottle Formula has no Linux bottle label Apr 2, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 2, 2023
Merged via the queue into Homebrew:master with commit cabf4e7 Apr 2, 2023
@github-actions github-actions bot added the outdated PR was locked due to age label May 3, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 3, 2023
@chenrui333 chenrui333 deleted the mandown-1.0.4 branch January 22, 2024 04:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. linux Linux is specifically affected no Linux bottle Formula has no Linux bottle outdated PR was locked due to age test failure CI fails while running the test-do block
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mandown 1.0.3 failed to build on OSX
4 participants
@chenrui333 @carlocab @p-linnane @BrewTestBot