Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to download and keep track of Firefox Focus instead/as well. #1

Closed
florian-s-code opened this issue Jun 25, 2019 · 6 comments

Comments

@florian-s-code
Copy link

Firefox Focus can be interesting to have as well as Firefox.
Most of the code could be reused to add this feature.
The current release directory is https://archive.mozilla.org/pub/android/focus/latest/

@Tobi823
Copy link
Owner

Tobi823 commented Jun 25, 2019

I also think that adding Firefox Focus (Firefox Klar in Germany, Austria and Switzerland) is a good idea.

Sadly https://archive.mozilla.org/pub/android/focus/latest/ doesn't have the current version (the latest release https://play.google.com/store/apps/details?id=org.mozilla.klar is from 17. July 2019) - we have to use the Github API (https://api.github.com/repos/mozilla-mobile/focus-android/releases) to check for the latest release from https://github.com/mozilla-mobile/focus-android/releases. I can do it - its no big deal.

But I've got no real idea to add this feature to the app without ruining the UI. Can you help me with the layout?

My first idea was introducing tabs for switching between the view for the "normal" Firefox and the Klar/Focus Firefox. But I think its not pretty enought. What do you think? My sketch:

2019_06_25_21_13_24_Android_Emulator_Pixel_2_API_28_5554

@Tobi823 Tobi823 mentioned this issue Jul 17, 2019
@dannycolin
Copy link

Talking about Focus and the GitHub API, would it be possible to also add Firefox Preview to the list?

(see: https://github.com/mozilla-mobile/fenix/releases)

@Tobi823
Copy link
Owner

Tobi823 commented Jul 25, 2019

Yes, it is possible. Github offers an API for quering the latest releases - for mozilla-mobile/fenix it is:

https://api.github.com/repos/mozilla-mobile/fenix/releases/latest

But I may be difficult to detect if the local installed Preview is really the latest app version.

I will look into it in the next weeks (sry, but the next two weeks I dont have time)

@Tobi823
Copy link
Owner

Tobi823 commented Jul 25, 2019

I'm going to change the UI.

The current work-in-progress-state:
https://notabug.org/attachments/652ff586-434c-4cd8-95ee-a79f6d4e2f9f

What do you think? Good enought?

@dannycolin
Copy link

But I may be difficult to detect if the local installed Preview is really the latest app version.

Shouldn't it be mostly the same code as what you use at the moment? I mean you can get Fenix version with packageInfo and compare it with the version returned by GitHub API.

You could use "https://api.github.com/repos/mozilla-mobile/fenix/releases" (without latest) to get an array of all the releases and pick the newest one that has prerelease set to false.

I will look into it in the next weeks (sry, but the next two weeks I dont have time)

No rush and no need to apologies. It 's already really nice of you to make that app ;).

What do you think? Good enought?

Looks good to me. I guess the green download button is to download/update all?

@Tobi823
Copy link
Owner

Tobi823 commented May 7, 2020

its now implemented. i'm going to release the new version in the next days.

@Tobi823 Tobi823 closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants