Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand CI and tests to support GEOS 3.9.0beta2 #1042

Merged
merged 4 commits into from
Dec 13, 2020
Merged

Expand CI and tests to support GEOS 3.9.0beta2 #1042

merged 4 commits into from
Dec 13, 2020

Conversation

mwtoews
Copy link
Member

@mwtoews mwtoews commented Dec 3, 2020

Supersedes #1041

Two important changes since the previous attempt:

  • No more awkward version differences for test_create_inconsistent_dimensionality.py
  • Within shapely.geos, it seems that load_dll('libgeos_c') is required to load geos-3.9.0beta2 on Linux, whereas load_dll('geos_c') was OK to open geos-3.9.0beta1 (and earlier) libraries. Without this change, the system geos_c library would have precidence in loading, despite the value of LD_LIBRARY_PATH.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 84.947% when pulling fdc51cf on mwtoews:geos-3.9.0beta2 into 1dc9230 on Toblerity:master.

@sgillies sgillies merged commit 611a0b3 into shapely:master Dec 13, 2020
@mwtoews mwtoews deleted the geos-3.9.0beta2 branch December 15, 2020 03:40
@jorisvandenbossche jorisvandenbossche mentioned this pull request Feb 1, 2021
Closed
mwtoews added a commit to mwtoews/shapely that referenced this pull request Feb 9, 2021
@mwtoews
Copy install_geos.sh from master (from shapely#1042)
a052676
mwtoews added a commit that referenced this pull request Feb 9, 2021
@mwtoews
Maint 1.7: backport linux builds to Github Actions (#1085)
b52e339 
* CI: move Travis linux builds to Github Actions
* Fix failing test from GEOS 3.9.0; closes #1079
* Copy install_geos.sh from master (from #1042)
* Avoid ModuleNotFoundError: No module named 'pylab'
* Manually cherry-pick parts of #997 to fix doctests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgillies sgillies sgillies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwtoews @coveralls @sgillies