Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auditwheel 2/3 compat #1047

Closed
wants to merge 3 commits into from
Closed

auditwheel 2/3 compat #1047

wants to merge 3 commits into from

Conversation

sgillies
Copy link
Contributor

@sgillies sgillies commented Dec 14, 2020

This is a "hotfix" with search path changes required by auditwheel versions > 3.0, which is required for Python 3.9.

We will not merge this into 1.7.x but we will need this for 1.8.

@coveralls
Copy link

coveralls commented Dec 14, 2020

Coverage Status

Coverage decreased (-1.8%) to 80.082% when pulling fc3e642 on auditwheel-3-compat into 54ef750 on maint-1.7.

@sgillies
Copy link
Contributor Author

sgillies commented Dec 15, 2020

I've uploaded a Shapely-1.7.1-1-cp39-cp39-manylinux1_x86_64.whl to https://pypi.org/project/Shapely/1.7.1/#files with the hotfix made up of the commits in this PR: https://patch-diff.githubusercontent.com/raw/Toblerity/Shapely/pull/1047.diff. My changes in fc3e642 required the list of lib paths to be sorted and in 3a3f91b we do sort them. I've installed the wheel on my thinkpad with Python 3.9.1 and a basic test works.

Python 3.9.1 (default, Dec 15 2020, 11:13:51)
[GCC 7.5.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> from shapely.geometry import Point
>>> Point(0, 0).buffer(10).area
313.6548490545939

This resolves the new issue reported in #1040 (comment).

If you've already downloaded and installed Shapely-1.7.1-cp39-cp39-manylinux1_x86_64.whl (the file from 2020-12-14 with no "-1" build tag), uninstall and remove it from your pip cache and reinstall, or do pip install -U shapely -I --force-reinstall --no-cache.

@daveisfera
Copy link

If you've already downloaded and installed Shapely-1.7.1-cp39-cp39-manylinux1_x86_64.whl (the file from 2020-12-14 with no "-1" build tag), uninstall and remove it from your pip cache and reinstall, or do pip install -U shapely -I --force-reinstall --no-cache.

Can an updated release be made? We updated to Python 3.9 last night and trying to invalidate all of the docker builds that will now have this bad setup can be tricky and if I'm understanding this correctly, there is also a code change to go along with this, so wouldn't a new version make sense anyways?

@sgillies
Copy link
Contributor Author

No, I will not make a 1.7.2 release for this. 1.7.1-1 is like a build-specific patch applied by a downstream packager.

@sgillies sgillies changed the base branch from maint-1.7 to master December 15, 2020 20:57
@sgillies sgillies changed the base branch from master to maint-1.7 December 15, 2020 20:58
@sgillies sgillies closed this Dec 15, 2020
@sgillies sgillies deleted the auditwheel-3-compat branch December 15, 2020 22:30
@daveisfera
Copy link

Will 1.7.1-1 be published to PYPI or is there a way for me as a user to specify it in requirement.txt to be sure it's working, because we're having to play wack-a-mole with docker layer caches to resolve the problem currently and it keeps creeping in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants