Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

friendlist access (add, delete, ...) causes crashes sometimes #1257

Closed
iphydf opened this issue Nov 4, 2018 · 1 comment
Closed

friendlist access (add, delete, ...) causes crashes sometimes #1257

iphydf opened this issue Nov 4, 2018 · 1 comment
Labels
P3 Low priority
Milestone

Comments

@iphydf
Copy link
Member

iphydf commented Nov 4, 2018

Based on #956.


between those 2 lines m->friendlist may point to old already freed address

Friend *newfriendlist = (Friend *)realloc(m->friendlist, num * sizeof(Friend));
if (newfriendlist == nullptr) {
return -1;
}
m->friendlist = newfriendlist;

ToxAV has other threads, so this may be accessed while invalid.

@iphydf iphydf added this to the v0.2.x milestone Nov 4, 2018
@iphydf iphydf added the P3 Low priority label Apr 27, 2020
@iphydf
Copy link
Member Author

iphydf commented Feb 4, 2022

Toxcore will have full locking and no interleaved access at all once the toxav separation PR is in.

@iphydf iphydf closed this as completed Feb 4, 2022
@iphydf iphydf modified the milestones: v0.2.x, meta Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Low priority
Projects
None yet
Development

No branches or pull requests

1 participant