Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple downloads with the same files names… #1

Open
Tokariew opened this issue Sep 19, 2020 · 2 comments
Open

multiple downloads with the same files names… #1

Tokariew opened this issue Sep 19, 2020 · 2 comments

Comments

@Tokariew
Copy link
Owner 

Downloading  macdows95_windows.zip  24.04 MiB
Downloading  dontgiveup_windows.zip  93.64 MiB
Downloading  magicat_windows.zip  77.83 MiB
Downloading  romansands_windows.zip  387.27 MiB

Files with the same name with always be redownloaded…
@Tokariew
Copy link
Owner Author

Tokariew commented Nov 1, 2020 •
edited
Loading

For couple of files HB provided multiple files to download on their site, but on api request they return files with the same url, but with different md5sums…

For now I manually excluded known for me files with this problem.
But in future probably some more robust version is needed. Probably checking reported size using request and comparing with that from Api and not downloading file.

Tokariew referenced this issue Apr 15, 2021
@Tokariew
Little rewrite
b644feb 
 - change restring to slugify
 - simplify some logic
 - add ability to download trove games
 - little more sensible names
 - hide known warnings
 - exlusion fix for issue 1
@Tokariew
Copy link
Owner Author

e3b37b8 -- this commit prevent redownloading and downloading for the first time.

The correct files should be download at first try. But user will get misleading messages in case that above check from b644feb will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Tokariew