Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break get_all_request into separate, more testable, function #27

Open
TomFaulkner opened this issue Jun 20, 2018 · 0 comments
Open

Break get_all_request into separate, more testable, function #27

TomFaulkner opened this issue Jun 20, 2018 · 0 comments
Labels
good first issue

Comments

@TomFaulkner
Copy link
Owner

Unit tests with actual fan data, including multiple variable on one line data, would be nice for this. As would unit tests in general, tbh.
@TomFaulkner TomFaulkner mentioned this issue Jun 20, 2018
Closed
@TomFaulkner TomFaulkner changed the title Break get_all_request cleanup into separate, more testabl, function Break get_all_request cleanup into separate, more testable, function Jun 24, 2018
@TomFaulkner TomFaulkner changed the title Break get_all_request cleanup into separate, more testable, function Break get_all_request into separate, more testable, function Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TomFaulkner