Data.Vector.Generic support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it is true that there is no real performance benefit for unboxed/storable vectors, it is important to provide `parVector` for all types of vectors so that other packages which may want to abstract over all vectors can use `parVector` regardless of whether or not any actual performance benefit is gained from its usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is true that there is no real performance benefit for
unboxed/storable vectors, it is important to provide
parVectorfor alltypes of vectors so that other packages which may want to abstract over
all vectors can use
parVectorregardless of whether or not any actualperformance benefit is gained from its usage.