Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom feature, now we can use custom color or image to customize handle and also add slider line between min and max #16

Merged
merged 2 commits into from
Feb 23, 2016

Conversation

fiantinangon
Copy link
Contributor

  • Add Slider distLine Between min and max
  • Add Slider distLine custom color (Now we can custom color between min and max sliderLine)
  • Add custom handle with image
  • Add custom handle with custom color
  • Modification example, adding two new features

- Add custom handle with custom color
- Modification example, adding two new features
Add Slider distLine with custom color, (custom line between min and max)
@fiantinangon fiantinangon changed the title Add two custom feature, now we can use custom color or image to customize handle Add custom feature, now we can use custom color or image to customize handle and also add slider line between min and max Oct 23, 2015
@TomThorpe
Copy link
Owner

Thanks very much for this, it's very appreciated! I'll try and take a look soon :-)

@fiantinangon
Copy link
Contributor Author

Your welcome @TomThorpe , hope this feature helpful for others :D

/**
*Hendle slider with custom image, you can set custom image for your hendle
*/
@property (nonatomic, strong) UIImage *handleWithImage;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be better named just handleImage

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay i'll change the name asap , thanks @TomThorpe

@TomThorpe
Copy link
Owner

hey!

Sorry for the delay, I’ve had a chance to look over this now.

It looks great! I'm very grateful, the image and line colour are both great additions! But could I ask for maybe a few changes please?

I’ve commented on the items where I think it would be good to have some changes. If you get chance to do it (no rush!) I’d be very happy to merge this.

Thanks!

@TomThorpe TomThorpe mentioned this pull request Oct 30, 2015
ClaudioTSM added a commit to ClaudioTSM/TTRangeSlider that referenced this pull request Feb 9, 2016
@ClaudioTSM ClaudioTSM mentioned this pull request Feb 9, 2016
@ClaudioTSM
Copy link
Contributor

Hello everybody!
I've forked this branch and implemented the feedback received. I've opened a new PR to hope this customisations can get to master.
Here if you want to contribute #26

Thanks

@fiantinangon
Copy link
Contributor Author

@ClaudioTSM thanks for the respond to improve the name 👍 , hope @TomThorpe merge this PR soon

@ClaudioTSM
Copy link
Contributor

👍

@TomThorpe TomThorpe merged commit 6eda4bd into TomThorpe:master Feb 23, 2016
@TomThorpe
Copy link
Owner

This was merged now. Many thanks to both of you for your efforts :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants