-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom feature, now we can use custom color or image to customize handle and also add slider line between min and max #16
Conversation
fiantinangon
commented
Oct 22, 2015
- Add Slider distLine Between min and max
- Add Slider distLine custom color (Now we can custom color between min and max sliderLine)
- Add custom handle with image
- Add custom handle with custom color
- Modification example, adding two new features
- Add custom handle with custom color - Modification example, adding two new features
Add Slider distLine with custom color, (custom line between min and max)
Thanks very much for this, it's very appreciated! I'll try and take a look soon :-) |
Your welcome @TomThorpe , hope this feature helpful for others :D |
/** | ||
*Hendle slider with custom image, you can set custom image for your hendle | ||
*/ | ||
@property (nonatomic, strong) UIImage *handleWithImage; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better named just handleImage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay i'll change the name asap , thanks @TomThorpe
hey! Sorry for the delay, I’ve had a chance to look over this now. It looks great! I'm very grateful, the image and line colour are both great additions! But could I ask for maybe a few changes please? I’ve commented on the items where I think it would be good to have some changes. If you get chance to do it (no rush!) I’d be very happy to merge this. Thanks! |
Hello everybody! Thanks |
@ClaudioTSM thanks for the respond to improve the name 👍 , hope @TomThorpe merge this PR soon |
👍 |
This was merged now. Many thanks to both of you for your efforts :-) |