Would like to add a flag to hide the labels above the slider controls… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Why? Two main reasons: 1. I think this makes for a cleaner API. The work-around mentioned in the header seems overly complicated and doesn't work well with Swift. It might be possible with Swift, but I was unable to downcast an `NSNull` or `AnyObject` to `NSNumberFormatter` and get back an `NSNull` in Obj-C. I was only ever able to get a `nil` which the other sort of unclear use-case in the API. If you set this property to `nil` you get no formatter style. Anyway ... I just wanted to turn off the labels. Seems to me a flag would be a much cleaner way to go about it. 2. I didn't need labels animated and following the thumb controls for my purposes. I would assume others don't either. What I've done: - Added a new `IBInspectable` flag named `hideLabels` which by default is set to `NO`. Setting it to `YES` or `true` will hide them. I've made sure that updating this property while building the UI will correctly update the Storyboard/XIB. Updated the comment in the header. - Maintained backward compatibility with the aforementioned label hiding rules so older consumers of this API don't break. I would also be in favor of removing the old behavior and making this a breaking change ... but that's probably not my call :-)/ - Updated the Storyboard to include an example without the labels. Though I didn't bother fixing AutoLayout problems. Perhaps I should? - Updated the readme.
|
Hi chefnobody, |
|
Hi @chefnobody, Sorry for my brief reply earlier. I've had a quick look at the code and it looks great. On your point about the number formatter you are spot on - what you've done is much better than before so thanks for updating that and fixing my hack! Merging :-) Tom |
TomThorpe
added a commit
that referenced
this pull request
Jan 11, 2016
Would like to add a flag to hide the labels above the slider controls…
|
Cheers Tom! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. Why? Two main reasons:
NSNullorAnyObjecttoNSNumberFormatterand get back anNSNullin Obj-C. I was only ever able to get anilwhich the other sort of unclear use-case in the API. If you set this property tonilyou get no formatter style. Anyway ... I just wanted to turn off the labels. Seems to me a flag would be a much cleaner way to go about it.What I've done:
IBInspectableflag namedhideLabelswhich by default is set toNO. Setting it toYESortruewill hide them. I've made sure that updating this property while building the UI will correctly update the Storyboard/XIB. Updated the comment in the header.