Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error for every link #19

Open
berot3 opened this issue Jul 22, 2019 · 5 comments
Open

error for every link #19

berot3 opened this issue Jul 22, 2019 · 5 comments

Comments

@berot3
Copy link

berot3 commented Jul 22, 2019

@TomasHubelbauer

I get an error for every link which was correct before. I now installed your extension for the first time.

It puts a "c:" infront of every link and says in the problems "The path c:\path doesn't exist on the disk".

I am on Windows.

I had to disable your extension for now :(

@TomasHubelbauer
Copy link
Owner

I know and I'm really sorry about this. I think something in the VS Code API about URL parsing changed and it causes this. I have to roll out a fix soon. In fact I disabled the extension myself for now while I haven't had time to fix it. I will try to make some time to fix this soon. Again, sorry for your bad experience. I will update this issue whenever I've managed to fix this.

@berot3
Copy link
Author

berot3 commented Jul 22, 2019

no worries, thanks for the update!

@pbeens
Copy link

pbeens commented Oct 7, 2019

I think this is because it is inserting back-slashes into the link when they should be slashes. I have to manually change all the links for them to work also.
An option to using '/' instead of '' in the path links would fix this.

@TomasHubelbauer
Copy link
Owner

Thanks! I'll try to use this fix when I have the time to look into this. I was hoping to rely on VS Code URL API to do the right thing but worst case I'll just replace the slashes as strings. Or maybe I just need to update the VS Code dependency version and the URL API will work right. In any case, I'm fairly positive I'll get to it before the end of this year.

@TomasHubelbauer
Copy link
Owner

Hi! Sorry for not maintaining the extension, I have not been very active on any of my personal projects for a long time now for personal reasons. That being said, VS Code seems to have rolled out a feature called "MarkDown link Intellisense" in a recent release and it should make this extension obsolete! Please check it out and let me know how you feel about it :) https://code.visualstudio.com/updates/v1_64#_markdown-path-intellisense I will likely pull this extension completely if this native feature covers its functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants