Correcting a redundant invokation of pollEvents method, that was perm… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anently emptying the event queue.
The project invokes "pollEvents" twice, consecutively : one time (l162) as the "events" variable is initialized and one more time immediately after, in the for loop (l166).
Watchkey documentation tells:
"Events are retrieved by invoking the key's pollEvents method. This method retrieves and removes all events accumulated for the object."
As a consequence, the for loop tries continuously to scan an emptied liste of events because no file event could happen inbetween.
The solution is to use the created variable ("events") instead of re-invoking the pollEvents method on line 166.
It was for me the only way to make directories display. Hope this helps (far from beeing an experienced coder).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…anently emptying the event queue.
The project invokes "pollEvents" twice, consecutively : one time (l162) as the "events" variable is initialized and one more time immediately after, in the for loop (l166).
Watchkey documentation tells:
"Events are retrieved by invoking the key's pollEvents method. This method retrieves and removes all events accumulated for the object."
As a consequence, the for loop tries continuously to scan an emptied liste of events because no file event could happen inbetween.
The solution is to use the created variable ("events") instead of re-invoking the pollEvents method on line 166.
It was for me the only way to make directories display. Hope this helps (far from beeing an experienced coder).