Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventStreams#ticks emits its value at time 0 (timer start) or at its given interval (timer end). #37

Closed

Conversation

JordanMartinez
Copy link
Contributor

The only think to check would be FxTimer's factory methods' javadoc. I'm guessing you will think of a simpler way of explaining it.

Note: I didn't implement ticks0 for non-"JavaFX Application" Threads.

…timer start) or at its given interval (timer end).
@TomasMikula
Copy link
Owner

I don't see any use for create0 and runLater0. Whoever wants to do that can just execute the action right away.

@TomasMikula
Copy link
Owner

My IDE setting is to use wildcard imports only for static imports and nothing else. It would be great if you could use the same settings for this project to avoid noise in the commits.

@JordanMartinez
Copy link
Contributor Author

I don't see any use for create0 and runLater0. Whoever wants to do that can just execute the action right away.

Should I remove those completely then?

My IDE setting is to use wildcard imports only for static imports and nothing else. It would be great if you could use the same settings for this project to avoid noise in the commits.

Ok. My IDE will optimize imports before it commits, so I'll go back and update the imports accordingly.
Still, why do you do that? Is there some advantage to it?

@TomasMikula
Copy link
Owner

I'm sure you can configure your IDE to not use * imports. Arguments can be made both for and against this convention. For me it is about being able to tell where a name comes from by just looking at the source code outside of any IDE (e.g. on GitHub). Another argument usually made is decreasing the chance of name clashes.

@JordanMartinez
Copy link
Contributor Author

Another argument usually made is increasing the chance of name clashes.

Makes sense. Thanks for explaining that. I've only dealt with that issue once: javafx.scene.Node clashed with groovy.xml.Node (or whatever path it was). However, Groovy allows import aliasing, so that wasn't really an issue for me.

@JordanMartinez
Copy link
Contributor Author

How's that?

@TomasMikula
Copy link
Owner

There's still some import shuffling noise, but the code looks good.

Some tests would be nice.

@JordanMartinez
Copy link
Contributor Author

I'll create a new PR without the import noise tomorrow.

I haven't ever written a test before. However, looking at TicksTest.java, it seems like deriving one off of the fxTest() won't be that hard.

@JordanMartinez
Copy link
Contributor Author

See the next pull request.

@JordanMartinez JordanMartinez deleted the ticksAtStartOrEnd branch November 20, 2015 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants