New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EventStreams#ticks emits its value at time 0 (timer start) or at its given interval (timer end). #37
EventStreams#ticks emits its value at time 0 (timer start) or at its given interval (timer end). #37
Conversation
…timer start) or at its given interval (timer end).
I don't see any use for |
My IDE setting is to use wildcard imports only for static imports and nothing else. It would be great if you could use the same settings for this project to avoid noise in the commits. |
Should I remove those completely then?
Ok. My IDE will optimize imports before it commits, so I'll go back and update the imports accordingly. |
I'm sure you can configure your IDE to not use |
Makes sense. Thanks for explaining that. I've only dealt with that issue once: javafx.scene.Node clashed with groovy.xml.Node (or whatever path it was). However, Groovy allows import aliasing, so that wasn't really an issue for me. |
How's that? |
There's still some import shuffling noise, but the code looks good. Some tests would be nice. |
I'll create a new PR without the import noise tomorrow. I haven't ever written a test before. However, looking at |
See the next pull request. |
The only think to check would be FxTimer's factory methods' javadoc. I'm guessing you will think of a simpler way of explaining it.
Note: I didn't implement
ticks0
for non-"JavaFX Application" Threads.