Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add javadoc to Val, StateMachine, and List-, Tuples-, and FingerTree-related classes and methods #64

Closed
wants to merge 6 commits into from

Conversation

JordanMartinez
Copy link
Contributor

WIP

I figured I should document this first to better understand how it works since this is still the part of ReactFX I don't fully understand.
Once I do, I'll better understand how Flowless works and thus how to solve some of its bugs.

@JordanMartinez JordanMartinez changed the title Add javadoc Add javadoc to List-related classes and methods Apr 8, 2017
@JordanMartinez JordanMartinez force-pushed the addJavadoc branch 4 times, most recently from ead7edf to 918fa6d Compare April 8, 2017 20:53
@JordanMartinez JordanMartinez force-pushed the addJavadoc branch 3 times, most recently from 7cd2e09 to ad34750 Compare April 8, 2017 22:08
@JordanMartinez
Copy link
Contributor Author

K, looks like I just need to work on FingerTree now.

@JordanMartinez JordanMartinez changed the title Add javadoc to List-related classes and methods Add javadoc to Val and List-, Tuples-, and FingerTree-related classes and methods Apr 9, 2017
@JordanMartinez JordanMartinez force-pushed the addJavadoc branch 2 times, most recently from a5df9df to 694364c Compare April 9, 2017 02:28
@JordanMartinez
Copy link
Contributor Author

K, I think this is done.

@JordanMartinez
Copy link
Contributor Author

I needed to update it due to getting a

ReactFX/reactfx/src/main/java/
    org/reactfx/util/SparseList.java:16: warning: no description for @param
 * @param <E>

Now it's done and ready for your feedback/review

@JordanMartinez
Copy link
Contributor Author

Hmm... I think that about sums it up. FingerTree could still have more documentation, but I'm content for right now.

@JordanMartinez JordanMartinez changed the title Add javadoc to Val and List-, Tuples-, and FingerTree-related classes and methods Add javadoc to Val, StateMachine, and List-, Tuples-, and FingerTree-related classes and methods Apr 16, 2017
@JordanMartinez JordanMartinez deleted the addJavadoc branch April 18, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant