when in "help" mode q should just quit out of help

[dustymabe]

It should just quit out of the help and not the whole application.

[TomasTomecek]

x kills buffers, q quits whole app. In vim :q kills buffers, so you're right that this is a bit confusing.

Not sure if change the behavior or keep it the way it is.

[dustymabe]

The tui I use the most is tig. In tig if I open "help" and press q it just closes the help. Come to think of it that is how it works with most "views" in tig. That would be my vote for user interface, but then again that doesn't allow you to have many different "views" open. I guess it is up to you.

[TomasTomecek]

I use tig too and you are right. Well at some point, bindings (and colors) will be configurable so this will be just a matter of configuration. In alot, d closes buffer and q quits the application, so that's where I was inspired most likely.

[dustymabe]

cool. btw for alot is there a copr for that by chance?

[TomasTomecek]

Nope, it's packaged in Fedora: https://admin.fedoraproject.org/pkgdb/package/alot/

[jpopelka]

In my case it'd be sufficient if the help was saying something like 'remove buffer (like this help screen)' because I couldn't associate 'remove buffer' with what I was looking for.

[dustymabe]

still hit this every time I go back to sen :)

[TomasTomecek]

@dustymabe to be honest, it's already done, but it's in my colosal-refactor branch, so this should be available sooner rather than later:
d5f35ab#diff-bf7821d5c013038b9e7d0bd3b360e613R42
d5f35ab#diff-68ed563bf187149952dc4275a3f57231R51

[TomasTomecek]

Available in 0.4.0.

🍺