Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider does not honour selected image size when choosing the background image #51

Open
PeterUpfold opened this issue Dec 1, 2012 · 1 comment
Assignees
Labels
Milestone

Comments

@PeterUpfold
Copy link
Member

Since the change to storing the image attachment ID instead of URL, if you pick a very large image for the background URL, but choose one of the smaller sizes (medium, large), this works initially in the editor, but when saved, the full-size image is used.

Total Slider should store the desired image size and use that as well as the attachment ID to determine which image URL to show at display-time.

@ghost ghost assigned PeterUpfold Dec 1, 2012
@chrisvanpatten
Copy link
Member

I think there's a lot of work to do w/r/t image sizes and positioning/cropping, which should be (in my estimation) a goal of TS 1.2, particularly as the new media uploader matures and we look to integrate with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants