Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create virtual algorithm class and concrete algorithm classes #112

Open
paskino opened this issue Mar 18, 2019 · 3 comments
Open

Create virtual algorithm class and concrete algorithm classes #112

paskino opened this issue Mar 18, 2019 · 3 comments
Assignees

Comments

@paskino
Copy link
Contributor

paskino commented Mar 18, 2019

Currently the algorithms used in the toolkit are repeated within the different functions. This code repetition may lead to error.

Let's create an iterative algorithm class with the same structure of the Algorithm in the Framework.

@dkazanc
Copy link
Collaborator

dkazanc commented Mar 18, 2019

I assume this means wrapping C/CUDA functions into C++ classes? Is it possible or one needs to change C syntax to C++ ?

@paskino
Copy link
Contributor Author

paskino commented Mar 18, 2019

possibly the largest change should be adding extern "C" to function definitions on the C++ code.

The main idea is to use the existing functions you developed in C/CUDA, not rewriting them. The object orientated structure should significantly reduce duplication of code.

@dkazanc
Copy link
Collaborator

dkazanc commented Mar 18, 2019

makes sense. Happy to support this where I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants