Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mask help text #257

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Improve mask help text #257

merged 7 commits into from
Jun 11, 2024

Conversation

DanicaSTFC
Copy link
Contributor

@DanicaSTFC DanicaSTFC commented May 24, 2024 •
edited

  • Edit mask help text
  • Edit documentation
  • Added spline curve instructions in both files.

Closes #248

Help text look:
mask help

@DanicaSTFC DanicaSTFC added this to the Version 24.0.0 milestone May 24, 2024
@DanicaSTFC DanicaSTFC self-assigned this May 24, 2024
paskino
paskino reviewed Jun 3, 2024
View reviewed changes
src/idvc/dvc_interface.py Outdated Show resolved Hide resolved
paskino
paskino reviewed Jun 3, 2024
View reviewed changes
Copy link
Contributor

@paskino paskino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you want to add all of my comment, but that is how the tracer works.

@DanicaSTFC DanicaSTFC requested a review from paskino June 5, 2024 19:18
paskino
paskino reviewed Jun 10, 2024
View reviewed changes
docs/source/dvc_steps.rst Outdated Show resolved Hide resolved
paskino
paskino reviewed Jun 10, 2024
View reviewed changes
docs/source/dvc_steps.rst Outdated Show resolved Hide resolved
paskino
paskino reviewed Jun 10, 2024
View reviewed changes
docs/source/dvc_steps.rst Outdated Show resolved Hide resolved
DanicaSTFC and others added 2 commits June 11, 2024 14:45
@DanicaSTFC @paskino
Apply suggestions from code review
023d125 
Co-authored-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com>
@DanicaSTFC
Add spaces
9fa95e6
@DanicaSTFC DanicaSTFC merged commit ee32ac7 into master Jun 11, 2024
3 checks passed
@DanicaSTFC DanicaSTFC deleted the improve-mask-help-text branch June 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paskino paskino paskino left review comments

@lauramurgatroyd lauramurgatroyd Awaiting requested review from lauramurgatroyd

Assignees

@DanicaSTFC DanicaSTFC

Labels
None yet
Projects
iDVC Planning
Archived in project
Milestone
Version 24.0.0
Development

Successfully merging this pull request may close these issues.

Improve mask help text
2 participants
@DanicaSTFC @paskino