Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gemspec] cleanup dependencies #44

Closed
wants to merge 1 commit into from
Closed

Conversation

mikz
Copy link
Contributor

@mikz mikz commented Oct 25, 2015

rack, cuba, celluloid, ... are pulled from airplay gem
no need to lock their versions here

fixes:

$ gem install airplayer
ERROR:  While executing gem ... (Gem::DependencyError)
    Unable to resolve dependencies: airplayer requires reel (= 0.4.0), reel-rack (= 0.1.0), celluloid (= 0.15.2); airplay requires celluloid (>= 0.17.0), reel (~> 0.5.0), reel-rack (~> 0.2.2); celluloid-io requires celluloid (>= 0.15.0)

rack, cuba, celluloid, ... are pulled from airplay gem
no need to lock their versions here

fixes:
$ gem install airplayer
ERROR:  While executing gem ... (Gem::DependencyError)
    Unable to resolve dependencies: airplayer requires reel (= 0.4.0), reel-rack (= 0.1.0), celluloid (= 0.15.2); airplay requires celluloid (>= 0.17.0), reel (~> 0.5.0), reel-rack (~> 0.2.2); celluloid-io requires celluloid (>= 0.15.0)
@mikz
Copy link
Contributor Author

mikz commented Oct 25, 2015

Unfortunately it looks like with newer celluloid it can't find my apple tv.
But the airplay gem does not work either.

@tomohiro
Copy link
Owner

Thanks.

Unfortunately it looks like with newer celluloid it can't find my apple tv.

I've got the same error on my environment.

Your branch:

$ git checkout -b mikz-dependencies master
$ git pull https://github.com/mikz/airplayer.git dependencies
$ bundle
$ bundle exec airplayer devices  # Can't find Apple TV

airplay-cli:

$ gem install airplay-cli  # This installs `air` command
$ air list                          # Can't find Apple TV

So, I'm going to investigate what caused this...

@tomohiro
Copy link
Owner

I think airplay's dependencies are broken. Hence I'd like to locking version of dependencies for a while.

Thus this PR is closing for now.

@tomohiro tomohiro closed this Jan 10, 2016
@mikz
Copy link
Contributor Author

mikz commented Jan 11, 2016

@tomohiro then airplayer has to use gem to lock the correct versions before requiring them.
Because if there is no gem locking the version, it will just use the latest one installed, regardless what you have in the gemspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants