Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

Broken with typescript 4.1.2 #53

Closed
merkys opened this issue Nov 26, 2020 · 1 comment
Closed

Broken with typescript 4.1.2 #53

merkys opened this issue Nov 26, 2020 · 1 comment

Comments

@merkys
Copy link

merkys commented Nov 26, 2020

node-agent-base fails to build from source with typescript 4.1.2:

$ tsc
src/promisify.ts(27,15): error TS2345: Argument of type 'Duplex | Pick<Agent, "addRequest"> | Agent | undefined' is not assignable to parameter of type 'Duplex | Pick<Agent, "addRequest"> | Agent | PromiseLike<AgentCallbackReturn>'.
  Type 'undefined' is not assignable to type 'Duplex | Pick<Agent, "addRequest"> | Agent | PromiseLike<AgentCallbackReturn>'.
@TooTallNate
Copy link
Owner

This code in this repository has been moved to the proxy-agents monorepo, so I am closing this pull request. If you feel that this issue still exists as of the latest release, feel free to open a new issue over there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants