Checking custom npm proxy before system defined proxy #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I'm encountering an issue with node-gyp as I need to have my Windows default proxy environment vars without the http:// prefix. Since node-gyp checks this prefix to validate the proxy url, I can't use it in an automated process (ie. github atom package install). The easiest solution I've found is to check the npm_config_proxy before the standard proxy vars. It works in my case but to me it also seems more logical as using it to override default proxy settings in node related operations is for me a common usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm encountering an issue with node-gyp as I need to have my Windows default proxy environment vars without the http:// prefix. Since node-gyp checks this prefix to validate the proxy url, I can't use it in an automated process (ie. github atom package install).
The easiest solution I've found is to check the npm_config_proxy before the standard proxy vars. It works in my case but to me it also seems more logical as using it to override default proxy settings in node related operations is for me a common usage.