Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a net.Socket instead of a plain EventEmitter for replaying proxy errors #83

Merged
merged 3 commits into from Oct 17, 2019

Conversation

@lpinca
Copy link
Contributor

@lpinca lpinca commented Oct 16, 2019

Fixes: #81

@lpinca
Copy link
Contributor Author

@lpinca lpinca commented Oct 16, 2019

Hmm there is no {readable,writable}.destroy() on Node.js 6.

index.js Outdated Show resolved Hide resolved
@lpinca lpinca force-pushed the gh-81 branch 2 times, most recently from f6e2538 to 093b8de Oct 16, 2019
var net = require('net');
var tls = require('tls');
var url = require('url');
var events = require('events');
var stream = require('stream');
Copy link
Owner

@TooTallNate TooTallNate Oct 16, 2019

Not used?

Copy link
Owner

@TooTallNate TooTallNate Oct 16, 2019

Suggested change
var stream = require('stream');

@TooTallNate
Copy link
Owner

@TooTallNate TooTallNate commented Oct 16, 2019

This looks great! Thanks for the PR

@TooTallNate TooTallNate changed the title Use a Duplex instead of a plain EventEmitter Use a net.Socket instead of a plain EventEmitter for replaying proxy erros Oct 16, 2019
@TooTallNate TooTallNate changed the title Use a net.Socket instead of a plain EventEmitter for replaying proxy erros Use a net.Socket instead of a plain EventEmitter for replaying proxy errors Oct 16, 2019
@TooTallNate TooTallNate merged commit 4c0d37e into TooTallNate:master Oct 17, 2019
12 checks passed
@lpinca lpinca deleted the gh-81 branch Oct 17, 2019
TooTallNate added a commit that referenced this issue Oct 25, 2019
…oxy errors (#83)

* Run CI on pull requests

* Use a `Duplex` instead of a plain `EventEmitter`

Fixes: #81

* Use a new and closed `net.Socket` instead of a `Duplex`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants