added support for writing JS strings to the "char" and "uchar" types

TooTallNate · May 30, 2012 · f9b4aac · f9b4aac
1 parent 313157f
commit f9b4aac
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/lib/ref.js b/lib/ref.js
@@ -337,6 +337,9 @@ exports.types.int8 = {
       return buf.readInt8(offset || 0)
     }
   , set: function set (buf, offset, val) {
+      if (typeof val === 'string') {
+        val = val.charCodeAt(0)
+      }
       return buf.writeInt8(val, offset || 0)
     }
 }
@@ -347,6 +350,9 @@ exports.types.uint8 = {
       return buf.readUInt8(offset || 0)
     }
   , set: function set (buf, offset, val) {
+      if (typeof val === 'string') {
+        val = val.charCodeAt(0)
+      }
       return buf.writeUInt8(val, offset || 0)
     }
 }

diff --git a/test/char.js b/test/char.js
@@ -0,0 +1,17 @@
+
+var assert = require('assert')
+var ref = require('../')
+
+describe('char', function () {
+
+  it('should accept a JS String, and write the first char\'s code', function () {
+    var val = 'a'
+
+    var buf = ref.alloc('char', val)
+    assert.strictEqual(val.charCodeAt(0), buf.deref())
+
+    buf = ref.alloc('uchar', val)
+    assert.strictEqual(val.charCodeAt(0), buf.deref())
+  })
+
+})