Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default loader color value for the button widget should be set to #fff #4244

Closed
arpitnath opened this issue Oct 3, 2022 · 15 comments
Closed
Assignees
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest up-for-grabs

Comments

@arpitnath
Copy link
Collaborator

arpitnath commented Oct 3, 2022

Version Information

Environment

Latest develop

What is the expected behaviour?

The default loader color value for the button widget should be set to #fff

What is the current behaviour?

The default value is not set for the loader color style definition.

How to reproduce the issue?

  1. Drop a Button widget into the editor
  2. Open the widget inspector and navigate to the styles tab

Any possible solutions?

Source: frontend/src/Editor/WidgetManager/widgetConfig.js ~ Line 486
Solution

      styles: {
        loaderColor: { value: '#fff' },
        ...
      },
@arpitnath arpitnath changed the title The default loader color value for the button widget should be set to #000 The default loader color value for the button widget should be set to #fff Oct 3, 2022
@Rahul-Palahwat
Copy link

Hey @arpitnath i would love to work on this issue , can you assign this issue to me

@Aman0786-git
Copy link

Can you assign this issue to me

@arpitnath
Copy link
Collaborator Author

Hi @Aman0786-git ,
Thanks for showing interest in contributing to ToolJet but we have to assign the issue to the first person who expressed interest.

You can check out other open issues here: https://github.com/ToolJet/ToolJet/issues?q=is%3Aissue+is%3Aopen+label%3Ahacktoberfest.

@Rahul-Palahwat Hello, assigning the issue to you.

If you have any questions related to setting up ToolJet, feel free to join our Slack community here: Slack community

@Rahul-Palahwat
Copy link

Thanks @arpitnath for assigning the issue , and i am on it

@ABHISHEK-PANDEY2
Copy link

from what i can experience , the button already has the default textColor as white(#fff), do you want the background color to change ?

@rushikeshadhav
Copy link

Hey, @Rahul-Palahwat are you still working on it?
If not I would like to take it up?

@shivani1706
Copy link

can you assign me this issue

@ismailbohra
Copy link

i can do this can you please assign me this issue

@tanishk-23
Copy link
Contributor

@withshubh can you please assign this issue to me?

@withshubh
Copy link
Contributor

Hey @Rahul-Palahwat
Any update on this?
If you're not working on it then let us know, we will assign the issue to someone else.

@withshubh
Copy link
Contributor

Unassigned @Rahul-Palahwat as there was no update for more than 20 days

@AyushK-101
Copy link
Contributor

Can I work on this? I've raised a PR for my current assignment

@withshubh
Copy link
Contributor

Assigned to you @AyushK-101

@AyushK-101
Copy link
Contributor

image

@withshubh I guess the issue was resolved, it shows loader color #fff by default

@withshubh
Copy link
Contributor

Thanks @AyushK-101

Closing the issue as it seems to be fixed. (cc: @arpitnath - checked on cloud)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest up-for-grabs
Projects
None yet
Development

No branches or pull requests

10 participants