Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolJet Database: The "Enter" key does not submit the "Create New Table" dialog box #7196

Closed
ShazanRizvi opened this issue Aug 3, 2023 · 13 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs

Comments

@ShazanRizvi
Copy link
Collaborator

Environment

All Environments

Description

When attempting to create a table in the ToolJet Database, pressing the "Enter" key does not trigger the submission of the "Create New Table" dialog box. To successfully create the table, users are required to manually click the "Create Table" button. The "Enter" key functionality is currently not supported for submitting the form.

Steps to Reproduce

  1. Open up ToolJet application and go to ToolJet Database from the sidebar icons.
  2. Click on the create new table button, a side dialog box with table name and column names opens up.
  3. Fill in the table name, the column names, datatype of columns.
  4. Try to submit this dialog box using the enter key on keyboard.

Expected Output

The "Create New Table" dialog box should have the capability to be submitted using the "Enter" key on the keyboard.
Screenshot 2023-08-03 at 1 44 58 PM

@itsajay1029
Copy link

I'd like to work on it. Please assign it to me @ShazanRizvi

@tejakummarikuntla
Copy link
Contributor

Thanks for your interest, @itsajay1029 . Assigned the issue to you.

@4ddx
Copy link

4ddx commented Aug 15, 2023

Hey @tejakummarikuntla, I'd like to take this up in case no one's working, as it's been a week

@GrowwithNaveen GrowwithNaveen added the bug Something isn't working label Sep 5, 2023
@tejakummarikuntla
Copy link
Contributor

Hey @itsajay1029 , Given the duration of the assignment with no recent updates, we need to unassign the task. Your understanding and cooperation in this matter are greatly appreciated.

@4ddx, would you be interested in taking this up?

@qayyum22
Copy link
Contributor

Hi @tejakummarikuntla , can you assign this to me?

@tejakummarikuntla
Copy link
Contributor

Hey @qayyum22 , thanks for your interest, Assigned the issue to you!

@amresh625
Copy link

Hey @ShazanRizvi,

can i solve these issues?

@qayyum22
Copy link
Contributor

qayyum22 commented Oct 8, 2023

@amresh625 i'm working on this issue.

@qayyum22
Copy link
Contributor

#7724

@Michael-Nwachukwu
Copy link

Can i ask what the status of this issue is? And if i can be assigned to it?

@karan-rathod-316
Copy link
Collaborator

Hi @Michael-Nwachukwu, this is currently under review and we are expecting some changes in PR. I can reassign the issue to you if there is no activity.

@Michael-Nwachukwu
Copy link

Michael-Nwachukwu commented Dec 31, 2023

Hi @karan-rathod-316 id be thrilled to work on it.> activity.

@karan-rathod-316
Copy link
Collaborator

Fixed in the below PR:
#7724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers up-for-grabs
Projects
None yet
Development

No branches or pull requests

9 participants