Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Amazon DocumentDb #8370

Open
akshaysasidrn opened this issue Dec 21, 2023 · 20 comments
Open

Add support for Amazon DocumentDb #8370

akshaysasidrn opened this issue Dec 21, 2023 · 20 comments

Comments

@akshaysasidrn
Copy link
Collaborator

Is your proposal related to a problem?

ToolJet cannot connect to Amazon DocumentDb. Even though DocumentDb is compatible with MongoDB client, we don't currently support the auth mechanism required to connect to it.

Describe the solution you'd like

We need to add explicit integration with DocumentDb using the official client as a part of our plugin catalogue.
https://www.npmjs.com/package/@aws-sdk/client-docdb

You can follow the steps here, for creating a plugin.

@Just-A-Pixel
Copy link
Contributor

Hello! Can I try this issue?

@harshbsharma
Copy link
Contributor

Please assign

@FurquanAnwer
Copy link

Please assign this issue to me !

@akshaysasidrn
Copy link
Collaborator Author

@Just-A-Pixel would you pick this up? Will assign.

@Just-A-Pixel
Copy link
Contributor

@akshaysasidrn yes I'd like to pickup this issue

@akshaysasidrn
Copy link
Collaborator Author

Have assigned. Happy coding!

@Just-A-Pixel
Copy link
Contributor

Hi @akshaysasidrn!
Apologies for the delay, some unavoidable circumstances led me to start late!

I looked into the problem and these are the concerns that I have:

  1. Should we be making an entirely new plugin to support documentDB? The functionality should be the same as Mongodb, so why are we not enhancing the existing Mongodb manifest.json to support it, instead?
  2. For all AWS-related plugins, I was wondering if having a common manifest (or similar) that handles aws auth would provide a better user and developer experience.

@609harsh
Copy link
Contributor

609harsh commented Mar 5, 2024

Hi @akshaysasidrn please assign this issue to me

@2001asjad
Copy link
Contributor

2001asjad commented Mar 21, 2024

Hey @Just-A-Pixel , are you still working on this issue? Do let us know if you're not going forward with it.

@2001asjad
Copy link
Contributor

Hello @609harsh, let us know if you would want to go forward working on the issue.

@Abhinav-CHD
Copy link
Contributor

Hi, is this still up for grabs? If yes, then please assign it to me.

@2001asjad
Copy link
Contributor

Sure, @Abhinav-CHD, since there have been no updates from the previous contributors, I am assigning this issue to you. Thanks for contributing to ToolJet.

@Abhinav-CHD
Copy link
Contributor

@2001asjad while going through the docs there is no mention of the Amazon DocumentDb, do I need to create a page in data-sources as well explaining how to use it?

@2001asjad
Copy link
Contributor

Hi @Abhinav-CHD, let me confirm with the team once, and I'll tell you. Thanks for your patience.

@2001asjad
Copy link
Contributor

Hey @Abhinav-CHD, we only need to create the plugin for this issue.

@Abhinav-CHD
Copy link
Contributor

Hi @2001asjad, do I need to integrate DocumentDb using TLS and if so, how do I access the global-bundle.pem file?

@2001asjad
Copy link
Contributor

Let me loop-in @akshaysasidrn , to confirm this.

@2001asjad
Copy link
Contributor

Hi @Abhinav-CHD , will you be able to go forward with the issue?

@Abhinav-CHD
Copy link
Contributor

Hi @2001asjad, yesterday I got confirmation from Akshay on Slack on using a different approach, will raise PR by today hopefully.

@Abhinav-CHD
Copy link
Contributor

Hi @2001asjad, this has almost been implemented just testing locally from my end, will push the code by the weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants