Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.7 #17

Closed
wants to merge 2 commits into from
Closed

Bevy 0.7 #17

wants to merge 2 commits into from

Conversation

Shatur
Copy link

@Shatur Shatur commented Apr 17, 2022

This PR contains two changes (separate commits) related to Bevy:

  • Previously used render feature is a group that contains unneeded stuff, like bevy_ui or bevy_text. Specified features in this PR is the required minimum. You can read more about in in this issue: Feature render depends on bevy_ui bevyengine/bevy#4202
  • Update to Bevy 0.7. All changes comes from this PR in Bevy, which I used to get information about what changed. But currently it crashes with the following error:
thread 'main' panicked at 'range end index 176 out of range for slice of length 160', .cargo/registry/src/github.com-1ecc6299db9ec823/bevy_render-0.7.0/src/mesh/mesh/mod.rs:241:17

So the PR is draft.

Previously used `render` feature is a group that contains unneeded
stuff, like `bevy_ui` or `bevy_text`. Specified features in this PR
is the required minimum.
@Toqozz Toqozz marked this pull request as ready for review April 18, 2022 00:55
@Toqozz
Copy link
Owner

Toqozz commented Apr 18, 2022

Is the crash an issue upstream with bevy or were you just unable to figure out the cause of it in bevy_debug_lines?

Also what example are you running to get the crash? I can't seem to reproduce.

@Shatur
Copy link
Author

Shatur commented Apr 18, 2022

were you just unable to figure out the cause of it in bevy_debug_lines

I think that the crash is caused by bevy_debug_lines.

Also what example are you running to get the crash? I can't seem to reproduce.

I running cargo run --example 3d --features="example_deps"

@ericvrp
Copy link

ericvrp commented Apr 21, 2022

any progress here?

@Shatur
Copy link
Author

Shatur commented Apr 21, 2022

It crashes, we don't know how to solve it currently.

@Shatur Shatur marked this pull request as draft April 21, 2022 07:57
@Toqozz
Copy link
Owner

Toqozz commented Apr 21, 2022

First crash is because bevy switched to u32's for mesh colors, which is a hassle but not too hard to fix.

Second issue is that bevy changed seems to require normals, uvs, and probably indices for custom meshes now, at least when using the SpecializedMeshPipeline, all of which would be pointless for us to provide since they aren't used.
I think the solution is probably going to have to be to switch to SpecializedRenderPipeline, but its a fair bit to figure out and I'm busy until the weekend

I'm considering just raising an issue with bevy to not require those properties on meshes that don't need it.

P.S: Could be wrong, maybe there's a flag I can set.

@Toqozz
Copy link
Owner

Toqozz commented Apr 25, 2022

Fix acquired, will push tomorrow-ish.

Thanks @superdump!

@Toqozz
Copy link
Owner

Toqozz commented May 3, 2022

Sorry for the delay. Bevy 0.7 should work with master. I feel like the colors may still be off but I'm not sure.

I'll push a crate update in a few days once we see if any issues arise.

Also, thank you for the pull request! I pulled the relevant changes in but not through GitHub, so I'll close this now. Feel free to comment though.

Thanks again!

@Toqozz Toqozz closed this May 3, 2022
@Shatur Shatur deleted the bevy-0.7 branch May 3, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants