Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the logic of the program #1

Merged
merged 16 commits into from Feb 11, 2022
Merged

Changed the logic of the program #1

merged 16 commits into from Feb 11, 2022

Conversation

SepehrRasouli
Copy link
Contributor

@SepehrRasouli SepehrRasouli commented Feb 11, 2022

Hi Torham , I changed the logic of the random_strings library to use random.sample and string library instead of actually declaring the characters.
I changed all of the random_strings class functions to staticmethod because they didn't use self.
I also added tests , and i ran them manually too , and they all pass.
I also added runtests.py file. This way you can easily run the tests with pre-defined configurations to show logs and etc.
I also added a function to generate random whitespaces.
I changed README.MD file too.
If the program has any problem , Please inform me.

@TorhamDev
Copy link
Owner

Thankful Glad you improve the code and added a new feature to it.

@TorhamDev TorhamDev merged commit b86178e into TorhamDev:main Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants